Commit 31319803cafd Raw commit »

commit

31319803cafd

parent

8e530fdd4714

branch

default

Reworked r25207/r25208. Before:

* `LOGIN_LAST_USER` was one key in release builds and a different key in debug builds.
* There was also `LOGIN_LAST_USER_FALLBACK`.
* AILoginWindowController always saved to `LOGIN_LAST_USER`; changing which key it really saved to was accomplished by changing the value of `LOGIN_LAST_USER`.

Now:

* `LOGIN_LAST_USER` is always the same key (the same key it was in r25206).
* In debug builds, there is also `LOGIN_LAST_USER_DEBUG`. In release builds, there is only `LOGIN_LAST_USER`.
* AILoginWindowController saves to `LOGIN_LAST_USER` in a release build, `LOGIN_LAST_USER_DEBUG` in a debug build.
* The definitions of `LOGIN_LAST_USER{,_DEBUG}` never change.

This should still provide the intended, positive effect (allowing a different profile choice to be saved for debug builds from the one saved for release builds). The negative effect (reincarnation of deleted profiles, #11146) is now gone. This may also fix the apparent profile deletion that some people are experiencing; I look forward to user feedback on b2.

Fixes #11146.

Who

Peter Hosey

When

26 September 2008