William Bowling is sharing code with you

Bitbucket is a code hosting site. Unlimited public and private repositories. Free for small teams.

Don't show this again

wbowling / adium (fork of adium / adium)

Fork of Adium for patches/improvements

Clone this repository (size: 338.7 MB): HTTPS / SSH 
hg clone https://bitbucket.org/wbowling/adium
hg clone ssh://hg@bitbucket.org/wbowling/adium
Filename Size Date modified Message
Logorrhea
AIAccountController.h 1.2 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIAccountController.m 8.6 KB Avoid creating a bad account on the wrong service for "preferred account" guesses.
AIAccountListPreferences.h 2.0 KB Convert a bunch of informal protocols to formal ones, taking advantage of @optional. Also propertyize one file a bit
AIAccountListPreferences.m 36.4 KB Backout pt2
AIAccountListPreferencesPlugin.h 1008 B Move AIPlugin.h into the pch as well; same reasoning
AIAccountListPreferencesPlugin.m 2.0 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AIAccountMenuAccessPlugin.h 1.0 KB Move AIPlugin.h into the pch as well; same reasoning
AIAccountMenuAccessPlugin.m 3.3 KB Convert a bunch of informal protocols to formal ones, taking advantage of @optional. Also propertyize one file a bit
AIAccountProxySettings.h 1.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIAccountProxySettings.m 8.9 KB Remove AIWired* and associated support code. OSX provides encrypted swap now, which accomplishes this in a better way system-wide
AIAddBookmarkPlugin.h 302 B Move AIPlugin.h into the pch as well; same reasoning
AIAddBookmarkPlugin.m 4.5 KB Make sure that bookmarks really end up in the right group on creation; fixes groups appearing when creating bookmarks with groups turned off
AIAddressBookInspectorPane.h 1.0 KB Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIAddressBookInspectorPane.m 3.2 KB More @classing
AIAdium.h 3.2 KB Make AILog always be compiled in, enabled by default in debug builds and enableable with a hidden pref in Release builds. The overhead for calling AILog when it's off is increased from nothing to completely trivial (one global var access plus one hinted branch), but I'll eat my hat if that ever matters. Putting in some sort of UI for this would be nice, but that can wait for a followup commit
AIAdium.m 52.9 KB Restraining myself from doing risky changes this close to 1.4, so, trivial cleanup of AIAdium.m
AIAdvancedInspectorPane.h 1.5 KB Avoid infinite-looping when a meta contact's contact on a particular account doesn't exist.
AIAdvancedInspectorPane.m 9.6 KB Remove as an observer after the notification is posted.
AIAdvancedPreferences.h 476 B Remove more AIAlternatingRowTableView usage
AIAdvancedPreferences.m 5.2 KB Use AIImageTextCell to center the text vertically in the advanced preferences pane
AIAdvancedPreferencesPlugin.h 362 B Create a new advanced preference called "Confirmations". Move Quit Confirmations there.
AIAdvancedPreferencesPlugin.m 618 B Create a new advanced preference called "Confirmations". Move Quit Confirmations there.
AIAliasSupportPlugin.h 1.3 KB Move AIPlugin.h into the pch as well; same reasoning
AIAliasSupportPlugin.m 10.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIAlphabeticalSort.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIAlphabeticalSort.m 5.7 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIAnimatingListOutlineView.h 463 B Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIAnimatingListOutlineView.m 14.4 KB Updated most of our enumerations to fast enumerations, and did some paramaterization.
AIAppearancePreferences.h 2.2 KB @class AIListGroup instead of importing
AIAppearancePreferences.m 40.0 KB Fix a number of leaks in AIAppearancePreferences
AIAppearancePreferencesPlugin.h 2.0 KB Remove the "Show [User Icon/Status Messages]" menu items from the View menu.
AIAppearancePreferencesPlugin.m 11.7 KB Remove the "Show [User Icon/Status Messages]" menu items from the View menu.
AIApplication.h 152 B Cleanup of various applescript code... removing unused code, and adding in intelligent error early-exits.
AIApplication.m 7.2 KB Contact list support for removing contacts in multiple groups.
AIAutoLinkingPlugin.h 1004 B Move AIPlugin.h into the pch as well; same reasoning
AIAutoLinkingPlugin.m 3.9 KB Merged [25242]
AIAutoReplyPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIAutoReplyPlugin.m 7.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIAutoScrollTextView.h 1.1 KB Remove unnecessary imports of cocoa/appkit/foundation
AIAutoScrollTextView.m 3.3 KB More
AIAutomaticStatus.h 1.5 KB Move AIPlugin.h into the pch as well; same reasoning
AIAutomaticStatus.m 10.7 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIBorderlessListController.h 236 B Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIBorderlessListController.m 1.6 KB The notification selector in the superclass was changed, but this subclassing of it wasn't fully updated. Fixes updating of the hidden/visible state of a borderless contact list based upon whether or not it contains any rows and is supposed to hide when empty. Fixes #12206
AIBorderlessListOutlineView.h 978 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIBorderlessListOutlineView.m 2.4 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIBorderlessListWindowController.h 975 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIBorderlessListWindowController.m 2.1 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AICLPreferences.h 2.2 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AICLPreferences.m 12.5 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
AICalendarDate.h 375 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AICalendarDate.m 1.1 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIChatConsolidationPlugin.h 985 B Move AIPlugin.h into the pch as well; same reasoning
AIChatConsolidationPlugin.m 2.9 KB Remove the unimplemented (wtf?) AIChatWindowController protocol, and use properties in more places. Fixes building with llvm-gcc
AIChatController.h 454 B Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIChatController.m 28.9 KB Make openChats return an immutable copy
AIChatCyclingPlugin.h 986 B Move AIPlugin.h into the pch as well; same reasoning
AIChatCyclingPlugin.m 4.5 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIChatLog.h 2.1 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIChatLog.m 12.7 KB More deprecated call removal
AIClickThroughThemeDocumentButton.h 298 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIClickThroughThemeDocumentButton.m 3.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIConfirmationsAdvancedPreferences.h 830 B Create a new advanced preference called "Confirmations". Move Quit Confirmations there.
AIConfirmationsAdvancedPreferences.m 5.7 KB Properly invert the BOOLs for the quit confirmations. Fixes #12817.
AIContactAwayPlugin.h 993 B Move AIPlugin.h into the pch as well; same reasoning
AIContactAwayPlugin.m 5.4 KB Dot syntax. Lots of it.
AIContactController.h 1.9 KB `#define` cleanup
AIContactController.m 54.3 KB Include bookmarks in the contact controller's contactDict, so that a -contactEnumerator also contains them. By way of updating properly, fixes #13221.
AIContactIdlePlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactIdlePlugin.m 6.6 KB Convert the unused idleTime property into an accessor for something we actually use, and move the callsites over to using it
AIContactInfoContentController.h 737 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIContactInfoContentController.m 1.6 KB Switch all of our private method categories over to the new objc way of doing it (documented at http://developer.apple.com/documentation/Cocoa/Conceptual/ObjectiveC/Articles/chapter_4_section_5.html#//apple_ref/doc/uid/TP30001163-CH20-SW2). This enforces having implementations for them, and in the process turned up a vast number of methods we had deleted the impl for but not the declaration. loc -= 198;
AIContactInfoImageViewWithImagePicker.h 411 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIContactInfoImageViewWithImagePicker.m 5.4 KB Paramaterizing and sythensizing various code
AIContactInfoWindowController.h 1.8 KB Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIContactInfoWindowController.m 12.1 KB Fast enumerate, etc...
AIContactInfoWindowPlugin.h 456 B Move AIPlugin.h into the pch as well; same reasoning
AIContactInfoWindowPlugin.m 9.7 KB Validate the get info toolbar item. If it's a group chat with a bookmark, enable. If it's a non group chat, enable. Otherwise disable. I am ignoring the case where you want to click in the user list because I think that's too confusing of behavior anyway.
AIContactListEditorPlugin.h 1.2 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactListEditorPlugin.m 14.2 KB Contact list support for removing contacts in multiple groups.
AIContactListImagePicker.h 372 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIContactListImagePicker.m 4.9 KB Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIContactListNameButton.h 430 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIContactListNameButton.m 3.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIContactListRecentImagesWindowController.h 768 B Xcode kept giving me random other copies of the header file, so I never actually made a few of the changes I thought I was making. Grrrr...
AIContactListRecentImagesWindowController.m 10.4 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIContactOnlineSincePlugin.h 996 B Move AIPlugin.h into the pch as well; same reasoning
AIContactOnlineSincePlugin.m 2.9 KB Implement a caching system for our date formatters. They showed up at 25% or so on a profile due to %shortTime% replacement in the wkmv
AIContactSortSelectionPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactSortSelectionPlugin.m 7.5 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIContactStatusColoringPlugin.h 2.4 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactStatusColoringPlugin.m 16.4 KB Remove pointless empty comments
AIContactStatusEventsPlugin.h 1.2 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactStatusEventsPlugin.m 21.9 KB Backout pt2
AIContactVisibilityControlPlugin.h 1.6 KB Move AIPlugin.h into the pch as well; same reasoning
AIContactVisibilityControlPlugin.m 12.2 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIContentController.h 1.4 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIContentController.m 32.4 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AICoreComponentLoader.h 1.0 KB Move AIPlugin.h into the pch as well; same reasoning
AICoreComponentLoader.m 5.8 KB Add a "Default font remover" plugin. Refs #12906 (though really fixes it).
AICrashController.h 940 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AICrashController.m 2.9 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AICreateCommand.h 942 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AICreateCommand.m 3.2 KB YES! This fixes #8863, which has been on my plate forever. Woot!
AIDefaultFontRemovalPlugin.h 695 B Add a "Default font remover" plugin. Refs #12906 (though really fixes it).
AIDefaultFontRemovalPlugin.m 2.2 KB Add a "Default font remover" plugin. Refs #12906 (though really fixes it).
AIDictionaryDebug.h 138 B objc2-ize AIDictionaryDebug and reenable it for 64 bit
AIDictionaryDebug.m 3.3 KB Convert our debug classes over to modern objc api
AIDockAccountStatusPlugin.h 989 B Move AIPlugin.h into the pch as well; same reasoning
AIDockAccountStatusPlugin.m 5.5 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIDockBehaviorPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIDockBehaviorPlugin.m 5.6 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AIDockController.h 1.4 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIDockController.m 21.0 KB Peter points out I can fast enumerate on an enumerator to still cleanly get the skip-first-object behavior here
AIDockIconPreviewController.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIDockIconPreviewController.m 2.4 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
AIDockIconSelectionSheet.h 1.5 KB Xcode kept giving me random other copies of the header file, so I never actually made a few of the changes I thought I was making. Grrrr...
AIDockIconSelectionSheet.m 10.2 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIDockUnviewedContentPlugin.h 1.0 KB Move AIPlugin.h into the pch as well; same reasoning
AIDockUnviewedContentPlugin.m 4.8 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIEditAccountWindowController.h 2.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIEditAccountWindowController.m 14.2 KB When editing an account, let the account know when editing is fully completed.
AIEmoticonController.h 1.5 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIEmoticonController.m 36.5 KB When replacing an emoticon in an attributed string, don't copy any previous attachments that string had into the replacement string. Fixes #12186.
AIEmoticonPreviewController.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIEmoticonPreviewController.m 2.3 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIEventSoundsPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIEventSoundsPlugin.m 4.3 KB Backed out changeset 8b455a7d180d
AIEventsInspectorPane.h 530 B Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIEventsInspectorPane.m 864 B More @classing
AIExceptionController.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIExceptionController.m 14.1 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIExtendedStatusPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
AIExtendedStatusPlugin.m 6.5 KB Convert the unused idleTime property into an accessor for something we actually use, and move the callsites over to using it
AIFileTransferProgressOutlineView.h 298 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIFileTransferProgressOutlineView.m 958 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIFilterBarBackgroundBox.h 915 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIFilterBarBackgroundBox.m 1.4 KB Convert AIFilterBarBackgroundBox to NSGradient. The one remaining user of CTGradient in Adium is ShortcutRecorder
AIFilterBarView.h 392 B Changing the variable name to drawsBackground, slight spacing fix.
AIFilterBarView.m 753 B Un-small-ize the rounded rectangle behind the filter bar. The filter bar is still set a few pixels too high compared to where it should be (in all cases), so this kind of looks a little off at the bottom still.
AIGroupChatStatusTooltipPlugin.h 241 B Move AIPlugin.h into the pch as well; same reasoning
AIGroupChatStatusTooltipPlugin.m 2.8 KB Stop throwing exceptions when hovering people in the twitter timeline on your contact list
AIGuestAccountWindowController.h 707 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIGuestAccountWindowController.m 4.5 KB Dot syntax. Lots of it.
AIHoveringPopUpButton.h 452 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIHoveringPopUpButton.m 6.3 KB Add appropriate class checks for all our +initialize impls that lacked them. I don't *think* this fixes anything, but it does make a few things subclassing-safe that weren't
AIHoveringPopUpButtonCell.h 597 B Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AIHoveringPopUpButtonCell.m 7.4 KB Remove unused Carbon.h import
AIIRCChannelLinker.h 205 B Move AIPlugin.h into the pch as well; same reasoning
AIIRCChannelLinker.m 5.3 KB Stop linking &local IRC channels, do not link text with quotes in it.
AIInfoInspectorPane.h 1.3 KB Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIInfoInspectorPane.m 28.5 KB Disable the 'always search user paths' option (it's only enabled by default for backwards compatibility with gcc3) and fix the resulting errors.
AIInterfaceController.h 3.5 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AIInterfaceController.m 71.0 KB Contact list support for removing contacts in multiple groups.
AIListController.h 2.3 KB Various fixes to compile properly with the new SL 64bit ABI. Fixes #10001
AIListController.m 39.3 KB Various fixes to compile properly with the new SL 64bit ABI. Fixes #10001
AIListLayoutWindowController.h 3.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIListLayoutWindowController.m 28.3 KB Remove pointless empty comments
AIListObjectContentsPlugin.h 1.1 KB Add tooltips for closed groups. Fixes #11951
AIListObjectContentsPlugin.m 9.0 KB Don't sort the contents when displaying a group or meta's tooltip. Fixes #12038.
AIListThemePreviewCell.h 1011 B I'm sorry about this long merge; I'm not sure how else to resolve so I can push
AIListThemePreviewCell.m 3.4 KB I'm sorry about this long merge; I'm not sure how else to resolve so I can push
AIListThemeWindowController.h 4.5 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIListThemeWindowController.m 28.1 KB Remove pointless empty comments
AIListWindowController.h 5.4 KB Magic nil arguments are evil.
AIListWindowController.m 59.7 KB Only slide on the Contact List for every Space if the preference is set
AILogDateFormatter.h 149 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AILogDateFormatter.m 1.9 KB Remove the Tiger branch and if from all isOnLeopardOrBetter checks in Adium. Next up: AIUtils
AILogFileUpgradeWindowController.h 344 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AILogFileUpgradeWindowController.m 380 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AILogFromGroup.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AILogFromGroup.m 2.8 KB Remove pointless empty comments
AILogToGroup.h 1.4 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AILogToGroup.m 5.7 KB Remove pointless empty comments
AILogViewerWindowController.h 6.7 KB Change the logger plugin to a) use a set for dirty logs so it's quicker to check in the path that blocks message sending, and b) not need the dirty logs property on chats, allowing us to avoid accidentally using KVC keys that contain non-ascii characters
AILogViewerWindowController.m 105.2 KB Dont ask for confirmation or try to delete 0 selected logs
AILoggerPlugin.h 3.6 KB Change the logger plugin to a) use a set for dirty logs so it's quicker to check in the path that blocks message sending, and b) not need the dirty logs property on chats, allowing us to avoid accidentally using KVC keys that contain non-ascii characters
AILoggerPlugin.m 59.0 KB Move away from NSThread in AILoggerPlugin, NSOperationQueue is our new friend.
AILoginController.h 1.3 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AILoginController.m 7.0 KB Remove pointless empty comments
AILoginWindowController.h 1.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AILoginWindowController.m 8.7 KB Select the last used debug user. This was lost in 31319803cafd
AIManualSort.h 949 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIManualSort.m 2.2 KB Remove now-needless indirection
AIMentionAdvancedPreferences.h 520 B Use NSPredicate for mention detection. Fixes #12831.
AIMentionAdvancedPreferences.m 2.9 KB Type fixes for adium. making it ready for 64-bit compiling.
AIMentionEventPlugin.h 1.2 KB Use NSPredicate for mention detection. Fixes #12831.
AIMentionEventPlugin.m 4.8 KB We don't need these AILogs here.
AIMenuBarIcons.h 1.3 KB Create a new Xtra—GroupChatStatusIcons—which is (at the moment, and possible for 1.4) uncustomizable. The default icon pack for this was stolen from Colloquy, so I named it appropriately "Colloquy". I hope somebody has a better idea to replace it, I just needed icons to use for testing. Moves AIXtraInfo into Adium.framework, and creates the AIGroupChatStatusIcons there. It uses a singleton (instead of instance methods like AIStatusIcons) to keep track of its icons.
AIMenuBarIcons.m 5.9 KB Create a new Xtra—GroupChatStatusIcons—which is (at the moment, and possible for 1.4) uncustomizable. The default icon pack for this was stolen from Colloquy, so I named it appropriately "Colloquy". I hope somebody has a better idea to replace it, I just needed icons to use for testing. Moves AIXtraInfo into Adium.framework, and creates the AIGroupChatStatusIcons there. It uses a singleton (instead of instance methods like AIStatusIcons) to keep track of its icons.
AIMenuController.h 5.9 KB Patch to add a contribute menu item. Fixes #12307
AIMenuController.m 21.2 KB Patch to add a contribute menu item. Fixes #12307
AIMenuItemView.h 662 B Propertyize a bunch of stuff
AIMenuItemView.m 9.3 KB Propertyize a bunch of stuff
AIMessageAlertsAdvancedPreferences.h 1.1 KB Move the dock icon preferences from Messages to Message Alerts. Force an update on DualWindowMessageAdvanced.nib for it.
AIMessageAlertsAdvancedPreferences.m 4.7 KB These are all boolean.
AIMessageHistoryPreferencesWindowController.h 612 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMessageHistoryPreferencesWindowController.m 2.8 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIMessageTabSplitView.h 308 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMessageTabSplitView.m 900 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMessageWindow.h 228 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMessageWindow.m 1.3 KB Fix another scripting leak. Thanks clang :)
AIMessageWindowOutgoingScrollView.h 242 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMessageWindowOutgoingScrollView.m 782 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMoveCommand.h 914 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIMoveCommand.m 2.6 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AINewBookmarkWindowController.h 831 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AINewBookmarkWindowController.m 5.8 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AINewContactWindowController.h 2.3 KB Oops. That was supposed to be the whole working copy, not the adium framework source...
AINewContactWindowController.m 18.1 KB Set the alias, now, before adding a contact to a group. We pass the alias to libpurple when adding, so this workaroundish thing isn't needed anymore.
AINewGroupWindowController.h 1.4 KB -existingGroupWithUID had only two callsites in Adium, both of which were doing exactly the same thing. A bit of tweaking easily reduces that to zero, with simpler code as a bonus :)
AINewGroupWindowController.m 3.1 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AINewMessagePanelPlugin.h 953 B Move AIPlugin.h into the pch as well; same reasoning
AINewMessagePanelPlugin.m 3.1 KB Propertyize a bunch of stuff, and remove some API on AIListObject that was just a passthrough to AIService
AINewMessagePromptController.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AINewMessagePromptController.m 2.8 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
AINoisyTableColumn.h 202 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AINoisyTableColumn.m 811 B Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AINulRemovalPlugin.h 205 B Move AIPlugin.h into the pch as well; same reasoning
AINulRemovalPlugin.m 1.8 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
AIObjectDebug.h 254 B warnings--
AIObjectDebug.m 2.9 KB Readability improvement Zac suggested
AIOutlineViewAnimation.h 435 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIOutlineViewAnimation.m 2.0 KB Paramaterizing and sythensizing various code
AIPasswordPromptController.h 2.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIPasswordPromptController.m 4.2 KB Remove AIWired* and associated support code. OSX provides encrypted swap now, which accomplishes this in a better way system-wide
AIPreferenceContainer.h 1.2 KB Delete prefs cache clearing the rest of the way
AIPreferenceContainer.m 14.1 KB D'oh, debug line (to cause tons and tons of Twitter messages) left in.
AIPreferenceController.h 1.6 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIPreferenceController.m 25.5 KB This could violate the fast enumeration rule in some situations. I really hate making copies in something that runs this often, but I can't think of another way to do it offhand.
AIPreferenceWindowController.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIPreferenceWindowController.m 4.2 KB Remove more AIAlternatingRowTableView usage
AIRealNameTooltip.h 215 B Move AIPlugin.h into the pch as well; same reasoning
AIRealNameTooltip.m 1.4 KB Expose and display the attributes of PurpleConvChatBuddies I added in [26956], namely userhost and realname for IRC contacts. On join, we WHO the channel, and store userhosts and realnames for users. I need to add a timeout to the IRC protocol to WHO regularly to get status and real names for users who joined, but that can come later.
AISCLViewPlugin.h 2.4 KB `#define` cleanup
AISCLViewPlugin.m 20.0 KB Missed two callsites.
AIScannerDebug.h 160 B 64-bitize and objc2-ize NSScannerDebug. rgov points out that this could be very unintuitive to debug, so we may want to just remove it. Has it been useful in the last year or two?
AIScannerDebug.m 1.0 KB 64-bitize and objc2-ize NSScannerDebug. rgov points out that this could be very unintuitive to debug, so we may want to just remove it. Has it been useful in the last year or two?
AISearchFieldCell.h 264 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AISearchFieldCell.m 946 B Remove the Tiger branch and if from all isOnLeopardOrBetter checks in Adium. Next up: AIUtils
AIServiceMenu.h 418 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIServiceMenu.m 4.1 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
AISoundController.h 1.1 KB Our core controller singletones are not subclassable. Enforce this with @private (added bonus, in 64 bit this reduces the number of symbols we export)
AISoundController.m 2.5 KB Backed out changeset 8b455a7d180d
AISpecialPasswordPromptController.h 856 B Add a new type of saved password—"special" passwords. Can be used for pretty much anything, but the only use of it now is the following.
AISpecialPasswordPromptController.m 5.1 KB Borrow some code from Colloquy's identification stuff to add a much wider range of NickServ/etc support.
AIStandardListScrollView.h 202 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIStandardListScrollView.m 882 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIStandardListWindowController.h 2.2 KB Copy and paste all of the filtering code from AIStandardListWindowController into AIListWindowController. This is currently a little ugly, but it works. Refs #10489.
AIStandardListWindowController.m 25.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIStandardToolbarItemsPlugin.h 922 B Move AIPlugin.h into the pch as well; same reasoning
AIStandardToolbarItemsPlugin.m 2.7 KB More dots, now with bonus for(in) action!
AIStateMenuPlugin.h 1.3 KB Move AIPlugin.h into the pch as well; same reasoning
AIStateMenuPlugin.m 8.9 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AIStatusChangedMessagesPlugin.h 1021 B Move AIPlugin.h into the pch as well; same reasoning
AIStatusChangedMessagesPlugin.m 8.1 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AIStatusController.h 1.9 KB Remove unused ivar
AIStatusController.m 43.6 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AIStatusIconPreviewController.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIStatusIconPreviewController.m 2.6 KB Updated most of our enumerations to fast enumerations, and did some paramaterization.
AIStringDebug.h 178 B This is 64-bit safe now. Thanks rgov :)
AIStringDebug.m 2.6 KB AIStringDebug should probably modify strings... copy-paste error I think
AITabStatusIconsPlugin.h 1.0 KB Move AIPlugin.h into the pch as well; same reasoning
AITabStatusIconsPlugin.m 5.0 KB Set a maximum height on the error/info window (Fixes #11793). Revert the behavior that only made request/info windows ordered front, since they keep getting lost, and it's just utterly annoying to have to tab to something like the "initiate direct IM" window.
AITextColorPreviewView.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AITextColorPreviewView.m 3.5 KB These imports are unnecessary, the pch handles it for us
AIToolbarController.h 1020 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIToolbarController.m 2.0 KB Preliminary conversion to using fast enumeration; caveats: variable declarations were not moved into loop headers. In *most* cases it should be safe to move them, but make sure the variable is not needed later on in the method. Also, AIContactController was not converted, because the conversion tool freaked out
AITwitterIMPlugin.h 201 B Move AIPlugin.h into the pch as well; same reasoning
AITwitterIMPlugin.m 1.1 KB Laconica and Twitter are too independent from each other - don't use the same service class for both (since there's definitely no way to communicate through either, and a "from"/"to" source is useless).
AIURLHandlerAdvancedPreferences.h 537 B Remove more AIAlternatingRowTableView usage
AIURLHandlerAdvancedPreferences.m 8.2 KB Type fixes for adium. making it ready for 64-bit compiling.
AIURLHandlerPlugin.h 976 B Move AIPlugin.h into the pch as well; same reasoning
AIURLHandlerPlugin.m 18.5 KB Missed using the display name for chat handle. Refs #11785.
AIURLShortenerPlugin.h 1.1 KB Added kl.am to the list of available URL shorteners, as requested by Jon Henshaw of Sitening (the company that runs kl.am).
AIURLShortenerPlugin.m 11.3 KB Added kl.am to the list of available URL shorteners, as requested by Jon Henshaw of Sitening (the company that runs kl.am).
AIUserHostTooltip.h 215 B Move AIPlugin.h into the pch as well; same reasoning
AIUserHostTooltip.m 1.4 KB Expose and display the attributes of PurpleConvChatBuddies I added in [26956], namely userhost and realname for IRC contacts. On join, we WHO the channel, and store userhosts and realnames for users. I need to add a timeout to the IRC protocol to WHO regularly to get status and real names for users who joined, but that can come later.
AIUserListOutlineView.h 193 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIUserListOutlineView.m 394 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIWindowDraggingView.h 221 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIWindowDraggingView.m 2.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXMLAppender.h 2.4 KB An AIXMLAppendXMLOperation showed up in my leaks output, which I suspect is due to throwing away an appender and it not releasing lastOp. We really have no need for that though, so this should avoid the leak and be simpler
AIXMLAppender.m 12.1 KB Patch from wixardy, fixes IRC Chat Logs Only Using 2 Lines
AIXMLChatlogConverter.h 2.0 KB NSDateFormatter is expensive to create, who knew? This speeds up log parsing by 50-60%
AIXMLChatlogConverter.m 14.8 KB Cheery picked from adium-1.4@07e07f9788a6: Undo the part of [3855f70905bd]: It caused strings to be incorrectly escaped and causing our XML parsing to break. Rather, escape hash-symbols when parsing in XML data as not to confuse AIHTMLDecoder.
AIXtraInfoController.h 1008 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXtraInfoController.m 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXtraPreviewController.h 991 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXtraPreviewImageController.h 309 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXtraPreviewImageController.m 458 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AIXtrasManager.h 2.3 KB Gut AIAlternatingRowTableView in favor of using NSTableView's new capabilities. This does lose the gradient on a few more tableviews, but that matches the rest of the OS. Can't remove it quite yet since it's still referenced in nibs
AIXtrasManager.m 18.4 KB Gut AIAlternatingRowTableView in favor of using NSTableView's new capabilities. This does lose the gradient on a few more tableviews, but that matches the rest of the OS. Can't remove it quite yet since it's still referenced in nibs
AdiumAccounts.h 1.5 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
AdiumAccounts.m 14.4 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
AdiumApplescriptRunner.h 481 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumApplescriptRunner.m 5.3 KB Preliminary conversion to using fast enumeration; caveats: variable declarations were not moved into loop headers. In *most* cases it should be safe to move them, but make sure the variable is not needed later on in the method. Also, AIContactController was not converted, because the conversion tool freaked out
AdiumChatEvents.h 411 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumChatEvents.m 8.4 KB Throttle Growl messages. Fixes #12133.
AdiumContentFiltering.h 2.7 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumContentFiltering.m 14.7 KB Updated most of our enumerations to fast enumerations, and did some paramaterization.
AdiumFormatting.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumFormatting.m 5.1 KB Only validate "Restore default formatting" if the attributes our defaults specify are modified in the current typing attributes. There's a whole mess of other attributes that the NSTextView may have, very few of which are specified as defaults.
AdiumIdleManager.h 218 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumIdleManager.m 5.2 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
AdiumMessageEvents.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumMessageEvents.m 17.2 KB Throttle Growl messages. Fixes #12133.
AdiumOTREncryption.h 1.3 KB Link against the new libotr.framework.
AdiumOTREncryption.m 48.1 KB Warnings--
AdiumPasswords.h 2.2 KB Add a new type of saved password—"special" passwords. Can be used for pretty much anything, but the only use of it now is the following.
AdiumPasswords.m 20.8 KB Patch up an NSInvocationOperation leak in AdiumPasswords.
AdiumPreferredAccounts.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumPreferredAccounts.m 6.3 KB Avoid creating a bad account on the wrong service for "preferred account" guesses.
AdiumServices.h 1.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumServices.m 3.8 KB More dot syntax. Hooray regexes
AdiumSetupWizard.h 1.4 KB Made the information about importing button localizable
AdiumSetupWizard.m 16.4 KB Fast enumerate, propertyize
AdiumSound.h 1.9 KB Backed out changeset 8b455a7d180d
AdiumSound.m 16.3 KB Fixed crash when changing notification volume level in preferences. Fixes #12965.
AdiumSoundSets.h 933 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumSoundSets.m 2.1 KB More deprecated call removal
AdiumSpeech.h 1.4 KB Remove SUSpeaker, since it's no longer useful as of 10.5
AdiumSpeech.m 8.4 KB Dammit, Zac, now you've got me doing it!
AdiumTyping.h 1009 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
AdiumTyping.m 6.5 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
ApplescriptRunner.m 6.6 KB Preliminary conversion to using fast enumeration; caveats: variable declarations were not moved into loop headers. In *most* cases it should be safe to move them, but make sure the variable is not needed later on in the method. Also, AIContactController was not converted, because the conversion tool freaked out
BGContactNotesPlugin.h 1.4 KB Move AIPlugin.h into the pch as well; same reasoning
BGContactNotesPlugin.m 2.3 KB Make -preferenceForKey:group: on AIListObject non-recursive, and eliminate the toggle version of it
BGEmoticonMenuPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
BGEmoticonMenuPlugin.m 11.6 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
BGICImportController.h 2.7 KB Eliminate Adium.h and its one use
BGICImportController.m 19.5 KB More fast enumeration
BGICLogImportController.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
BGICLogImportController.m 6.1 KB Completes [26431], but doesn't revert [25499]. Modifies AIXMLAppender to use AIXMLElements instead of NSXMLElements (which lack the ability to put spaces between elements, log > as >, which are major killjoys). Fixes all the issues I've found with logging.
CBActionSupportPlugin.h 996 B Move AIPlugin.h into the pch as well; same reasoning
CBActionSupportPlugin.m 4.0 KB Add "action" to the display classes of action messages. Fixes #11894.
CBContactCountingDisplayPlugin.h 1.1 KB Rename "Show Group Visible Count" back into "Show Group Online Count". Fixes #11362.
CBContactCountingDisplayPlugin.m 8.3 KB Patch from yelly to fix a few CodingStyle violations from 6ac7f22.
CBContactLastSeenPlugin.h 993 B Move AIPlugin.h into the pch as well; same reasoning
CBContactLastSeenPlugin.m 5.8 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
CBGrowlAlertDetailPane.h 1.1 KB Add a Growl event option to set the priority (Very Low, Moderate, High, High, Emergency). Fixes #2295.
CBGrowlAlertDetailPane.m 3.9 KB Add a Growl event option to set the priority (Very Low, Moderate, High, High, Emergency). Fixes #2295.
DCJoinChatPanelPlugin.h 979 B Move AIPlugin.h into the pch as well; same reasoning
DCJoinChatPanelPlugin.m 2.3 KB Updated most of our enumerations to fast enumerations, and did some paramaterization.
DCMessageContextDisplayPlugin.h 2.3 KB Move AIPlugin.h into the pch as well; same reasoning
DCMessageContextDisplayPlugin.m 16.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
DCMessageContextDisplayPreferences.h 1.6 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
DCMessageContextDisplayPreferences.m 6.2 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
DeadStrings-1.0.h 541 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
DeadStrings-1.1.h 0 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
EBChatCommandsController.h 893 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
EBChatCommandsController.m 4.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAccountEvents.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
ESAccountEvents.m 8.9 KB Backout pt2
ESAccountNetworkConnectivityPlugin.h 1.2 KB Move AIPlugin.h into the pch as well; same reasoning
ESAccountNetworkConnectivityPlugin.m 14.0 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
ESAccountPasswordPromptController.h 1.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAccountPasswordPromptController.m 4.8 KB More dot syntax. Hooray regexes
ESAddressBookIntegrationAdvancedPreferences.h 1.8 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAddressBookIntegrationAdvancedPreferences.m 13.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESAnnouncerAbstractDetailPane.h 1.5 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAnnouncerAbstractDetailPane.m 7.9 KB Remove SUSpeaker, since it's no longer useful as of 10.5
ESAnnouncerPlugin.h 1.6 KB Move AIPlugin.h into the pch as well; same reasoning
ESAnnouncerPlugin.m 11.2 KB Remove SUSpeaker, since it's no longer useful as of 10.5
ESAnnouncerSpeakEventAlertDetailPane.h 993 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAnnouncerSpeakEventAlertDetailPane.m 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAnnouncerSpeakTextAlertDetailPane.h 1.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESAnnouncerSpeakTextAlertDetailPane.m 2.9 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESApplescriptContactAlertPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
ESApplescriptContactAlertPlugin.m 4.0 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
ESAwayStatusWindowController.h 716 B Gut AIAlternatingRowTableView in favor of using NSTableView's new capabilities. This does lose the gradient on a few more tableviews, but that matches the rest of the OS. Can't remove it quite yet since it's still referenced in nibs
ESAwayStatusWindowController.m 11.8 KB Assorted cleanup. Fast enumeration, early returns, indenting, simplification
ESAwayStatusWindowPlugin.h 329 B Move AIPlugin.h into the pch as well; same reasoning
ESAwayStatusWindowPlugin.m 3.9 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESBlockingPlugin.h 1.2 KB Move AIPlugin.h into the pch as well; same reasoning
ESBlockingPlugin.m 20.5 KB Don't hardcode formats for images
ESCLViewAdvancedPreferences.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESCLViewAdvancedPreferences.m 4.8 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
ESCLViewLabelsAdvancedPrefs.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESCLViewLabelsAdvancedPrefs.m 5.1 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
ESContactAlertsController.h 1.1 KB Add appropriate class checks for all our +initialize impls that lacked them. I don't *think* this fixes anything, but it does make a few things subclassing-safe that weren't
ESContactAlertsController.m 30.1 KB Throttle Growl messages. Fixes #12133.
ESContactClientPlugin.h 992 B Move AIPlugin.h into the pch as well; same reasoning
ESContactClientPlugin.m 1.9 KB AIMetaContact now displays properties only for its preferred contact. This cleans up a fair amount of code and provides a more intuitive behavior in many cases. Fixes #11007
ESContactListAdvancedPreferences.h 934 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESContactListAdvancedPreferences.m 4.2 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESContactServersideDisplayName.h 1000 B Move AIPlugin.h into the pch as well; same reasoning
ESContactServersideDisplayName.m 2.3 KB Dot syntax. Lots of it.
ESContactSortConfigurationWindowController.h 1.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESContactSortConfigurationWindowController.m 3.5 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESDebugController.h 1.2 KB Make AILog always be compiled in, enabled by default in debug builds and enableable with a hidden pref in Release builds. The overhead for calling AILog when it's off is increased from nothing to completely trivial (one global var access plus one hinted branch), but I'll eat my hat if that ever matters. Putting in some sort of UI for this would be nice, but that can wait for a followup commit
ESDebugController.m 6.8 KB I see no reason to not use #import for everything. Apple's compiler supports it fine in .c files, and it doesn't seem to have any downsides vs #include unless you're playing silly multiple inclusion tricks
ESDebugWindowController.h 1.5 KB Make AILog always be compiled in, enabled by default in debug builds and enableable with a hidden pref in Release builds. The overhead for calling AILog when it's off is increased from nothing to completely trivial (one global var access plus one hinted branch), but I'll eat my hat if that ever matters. Putting in some sort of UI for this would be nice, but that can wait for a followup commit
ESDebugWindowController.m 5.4 KB Make AILog always be compiled in, enabled by default in debug builds and enableable with a hidden pref in Release builds. The overhead for calling AILog when it's off is increased from nothing to completely trivial (one global var access plus one hinted branch), but I'll eat my hat if that ever matters. Putting in some sort of UI for this would be nice, but that can wait for a followup commit
ESDockAlertDetailPane.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESDockAlertDetailPane.m 3.5 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
ESEditStatusGroupWindowController.h 703 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESEditStatusGroupWindowController.m 4.8 KB Dot syntax. Lots of it.
ESEventSoundAlertDetailPane.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESEventSoundAlertDetailPane.m 8.8 KB Backed out changeset 8b455a7d180d
ESFileTransferController.h 1.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESFileTransferController.m 37.6 KB Throttle Growl messages. Fixes #12133.
ESFileTransferMessagesPlugin.h 922 B Move AIPlugin.h into the pch as well; same reasoning
ESFileTransferMessagesPlugin.m 5.5 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
ESFileTransferPreferences.h 1.6 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESFileTransferPreferences.m 6.8 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
ESFileTransferProgressRow.h 1.8 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
ESFileTransferProgressRow.m 17.1 KB Dot syntax. Lots of it.
ESFileTransferProgressView.h 3.1 KB Patch from '''tarragon''' to hide the "stop" button on a successful transfer, and replace it with a "resend" button on an outgoing unsuccessful transfer. Fixes #9446. Thanks!
ESFileTransferProgressView.m 15.1 KB This is old and wrong, as far as I can tell. Also it crashes.
ESFileTransferProgressWindowController.h 2.0 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
ESFileTransferProgressWindowController.m 16.6 KB D'oh, unset the key equivalent when not selected. Clear the selection when removing a FT.
ESFileTransferRequestPromptController.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESFileTransferRequestPromptController.m 4.4 KB Added a suppression checkbox to ESTextAndButtonsWindow and updated callbacks to handle the extra return value. Also changed the quit confirmation to use the suppression instead of a button.
ESGlassSplitView.h 243 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESGlassSplitView.m 2.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESGlobalEventsPreferences.h 1.6 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESGlobalEventsPreferences.m 27.4 KB Backed out changeset 8b455a7d180d
ESGlobalEventsPreferencesPlugin.h 2.3 KB Move AIPlugin.h into the pch as well; same reasoning
ESGlobalEventsPreferencesPlugin.m 11.0 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
ESOTRFingerprintDetailsWindowController.h 682 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESOTRFingerprintDetailsWindowController.m 3.2 KB Link against the new libotr.framework.
ESOTRPreferences.h 1.4 KB Convert a bunch of informal protocols to formal ones, taking advantage of @optional. Also propertyize one file a bit
ESOTRPreferences.m 8.6 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
ESOTRPrivateKeyGenerationWindowController.h 535 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESOTRPrivateKeyGenerationWindowController.m 2.9 KB Switch all of our private method categories over to the new objc way of doing it (documented at http://developer.apple.com/documentation/Cocoa/Conceptual/ObjectiveC/Articles/chapter_4_section_5.html#//apple_ref/doc/uid/TP30001163-CH20-SW2). This enforces having implementations for them, and in the process turned up a vast number of methods we had deleted the impl for but not the declaration. loc -= 198;
ESOTRUnknownFingerprintController.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESOTRUnknownFingerprintController.m 7.2 KB Added a suppression checkbox to ESTextAndButtonsWindow and updated callbacks to handle the extra return value. Also changed the quit confirmation to use the suppression instead of a button.
ESPanelApplescriptDetailPane.h 1.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESPanelApplescriptDetailPane.m 3.2 KB Switch all of our private method categories over to the new objc way of doing it (documented at http://developer.apple.com/documentation/Cocoa/Conceptual/ObjectiveC/Articles/chapter_4_section_5.html#//apple_ref/doc/uid/TP30001163-CH20-SW2). This enforces having implementations for them, and in the process turned up a vast number of methods we had deleted the impl for but not the declaration. loc -= 198;
ESPersonalPreferences.h 727 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESPersonalPreferences.m 8.3 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESPersonalPreferencesPlugin.h 160 B Move AIPlugin.h into the pch as well; same reasoning
ESPersonalPreferencesPlugin.m 625 B AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESProxyPasswordPromptController.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESProxyPasswordPromptController.m 4.4 KB Propertyize AIListObject and convert some more controller accesses to dot syntax
ESRankingCell.h 967 B Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
ESRankingCell.m 1.7 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
ESSafariLinkToolbarItemPlugin.h 919 B Move AIPlugin.h into the pch as well; same reasoning
ESSafariLinkToolbarItemPlugin.m 5.5 KB Remove stray import I missed... doesn't seem to be needed
ESShowContactInfoPromptController.h 313 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESShowContactInfoPromptController.m 2.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESSourceListBackgroundView.h 202 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESSourceListBackgroundView.m 1.7 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
ESStatusAdvancedPreferences.h 374 B Create a new advanced preference called "Confirmations". Move Quit Confirmations there.
ESStatusAdvancedPreferences.m 1.1 KB Create a new advanced preference called "Confirmations". Move Quit Confirmations there.
ESStatusPreferences.h 1.5 KB Programmatically force alternating rows. I didn't feel like updating the nibs for this.
ESStatusPreferences.m 26.8 KB Programmatically force alternating rows. I didn't feel like updating the nibs for this.
ESStatusPreferencesPlugin.h 356 B Move AIPlugin.h into the pch as well; same reasoning
ESStatusPreferencesPlugin.m 1.8 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
ESStatusSort.h 1.8 KB Add "Sort Groups Alphabetically" option to the status sort.
ESStatusSort.m 24.8 KB Build fix :(
ESUserIconHandlingPlugin.h 1023 B Move AIPlugin.h into the pch as well; same reasoning
ESUserIconHandlingPlugin.m 10.5 KB AIPreferenceControllerProtocol.h is commonly imported (>120 imports) and almost never changes (5 changes in the two years since it was created). Stick it in the prefix header
ESiTunesPlugin.h 980 B Move AIPlugin.h into the pch as well; same reasoning
ESiTunesPlugin.m 33.7 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
GBApplescriptFiltersPlugin.h 1.4 KB Move AIPlugin.h into the pch as well; same reasoning
GBApplescriptFiltersPlugin.m 24.5 KB I see no reason to not use #import for everything. Apple's compiler supports it fine in .c files, and it doesn't seem to have any downsides vs #include unless you're playing silly multiple inclusion tricks
GBFireImporter.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
GBFireImporter.m 20.6 KB Fast enumerate, etc...
GBFireLogImporter.h 1.9 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
GBFireLogImporter.m 29.0 KB Added a suppression checkbox to ESTextAndButtonsWindow and updated callbacks to handle the extra return value. Also changed the quit confirmation to use the suppression instead of a button.
GBImportPlugin.h 937 B Move AIPlugin.h into the pch as well; same reasoning
GBImportPlugin.m 3.0 KB Adds "Reindex Adium Logs" to the Import menu. When the user manually adds logs to our Logs folder, we don't know they are new, so we don't bother to dirty them. This forces all logs to be marked as dirty. Fixes #9554.
GBQuestionHandlerPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
GBQuestionHandlerPlugin.m 4.5 KB Added a suppression checkbox to ESTextAndButtonsWindow and updated callbacks to handle the extra return value. Also changed the quit confirmation to use the suppression instead of a button.
IKRecentPicture.h 1.9 KB Merge 64 bit branch to trunk. Fingers crossed, and I have been testing it some, but expect fallout from this. 11,000 line diffs are rarely without consequence ;)
KNShelfSplitView.h 3.9 KB This ivar seems totally unecessary to me, and removing it helped patch up a fairly common leak.
KNShelfSplitView.m 21.0 KB This ivar seems totally unecessary to me, and removing it helped patch up a fairly common leak.
LNAboutBoxController.h 1.6 KB Patch from '''wixardy''' to make the about box scrollable. Fixes #9967.
LNAboutBoxController.m 5.6 KB Backed out changeset 8b455a7d180d
NEHGrowlPlugin.h 1.4 KB Growl 1.2 final, -WithInstaller framework.
NEHGrowlPlugin.m 24.1 KB Growl 1.2 final, -WithInstaller framework.
NSDataAdditions.h 1.0 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
NSDataAdditions.m 1.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
NSStringScriptingAdditions.h 938 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
NSStringScriptingAdditions.m 1.3 KB Preliminary conversion to using fast enumeration; caveats: variable declarations were not moved into loop headers. In *most* cases it should be safe to move them, but make sure the variable is not needed later on in the method. Also, AIContactController was not converted, because the conversion tool freaked out
NSThemeDocumentButton.h 115 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
NSWindowScriptingAdditions.h 989 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
NSWindowScriptingAdditions.m 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
OTRCommon.h 127 B Link against the new libotr.framework.
OWABSearchWindowController.h 2.4 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
OWABSearchWindowController.m 16.1 KB Updated most of our enumerations to fast enumerations, and did some paramaterization.
OWSpellingPerContactPlugin.h 987 B Move AIPlugin.h into the pch as well; same reasoning
OWSpellingPerContactPlugin.m 5.3 KB Clean up the per-contact spelling a little. I think this fixes #12359.
PTHotKey.h 728 B This updates to the latest PTHotKey code I could find, and applies http://rogueamoeba.com/sources/HotKeys3-105SDK.patch on top of that to avoid using the deprecated KL* APIs. It also converts SRKeyCodeTransformer to use PTKeyCodeTranslater behind the scenes, allowing it to avoid said APIs as well. Fixes 8 or so warnings, and is another step towards 64 bit clean.
PTHotKey.m 1.5 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
PTHotKeyCenter.h 620 B Remove redundant imports and 10.1 compatibility code
PTHotKeyCenter.m 4.7 KB Remove redundant imports and 10.1 compatibility code
PTKeyCodeTranslator.h 541 B I see no reason to not use #import for everything. Apple's compiler supports it fine in .c files, and it doesn't seem to have any downsides vs #include unless you're playing silly multiple inclusion tricks
PTKeyCodeTranslator.m 1.9 KB Er, let's do _this_ the right way.
PTKeyCombo.h 842 B This updates to the latest PTHotKey code I could find, and applies http://rogueamoeba.com/sources/HotKeys3-105SDK.patch on top of that to avoid using the deprecated KL* APIs. It also converts SRKeyCodeTransformer to use PTKeyCodeTranslater behind the scenes, allowing it to avoid said APIs as well. Fixes 8 or so warnings, and is another step towards 64 bit clean.
PTKeyCombo.m 5.0 KB Allow shortcut keys with the letter 'a'. Fixes #12013.
RAFBlockEditorPlugin.h 404 B Move AIPlugin.h into the pch as well; same reasoning
RAFBlockEditorPlugin.m 1.2 KB Fast enumerate, propertyize
RAFBlockEditorWindowController.h 1.7 KB Gut AIAlternatingRowTableView in favor of using NSTableView's new capabilities. This does lose the gradient on a few more tableviews, but that matches the rest of the OS. Can't remove it quite yet since it's still referenced in nibs
RAFBlockEditorWindowController.m 26.5 KB Having a separate notification center for Adium leads to the possibility of accidentally using the wrong one, which has tripped me up on more than one occasion. This switches us over to using the default center.
SAContactOnlineForPlugin.h 994 B Move AIPlugin.h into the pch as well; same reasoning
SAContactOnlineForPlugin.m 2.4 KB Dot syntax. Lots of it.
SMContactListShowBehaviorPlugin.h 1.1 KB Move AIPlugin.h into the pch as well; same reasoning
SMContactListShowBehaviorPlugin.m 5.2 KB sed is evil. All [adium *Controller]s are now adium.*Controller.
SMContactListShowDetailsPane.h 1.1 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
SMContactListShowDetailsPane.m 2.2 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
SetupAssistantBoxBackgroundView.h 222 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
SetupAssistantBoxBackgroundView.m 501 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
SetupWizardBackgroundView.h 363 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
SetupWizardBackgroundView.m 2.2 KB Oops. Thanks Peter :)
XtrasInstaller.h 1.3 KB svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk
XtrasInstaller.m 9.8 KB Fast enumerate, etc...
main.m 85 B svn 1.5 merge tracking is terrible. This is a manual merge of the Sparkle 1.5 branch into trunk